[webkit-reviews] review denied: [Bug 60783] Switch addFocusRingRects to use IntSize : [Attachment 93511] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 60783: Switch addFocusRingRects to use IntSize
https://bugs.webkit.org/show_bug.cgi?id=60783

Attachment 93511: Patch
https://bugs.webkit.org/attachment.cgi?id=93511&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93511&action=review

> Source/WebCore/rendering/RenderBlock.cpp:5852
> +void RenderBlock::addFocusRingRects(Vector<IntRect>& rects, const IntSize&
offset)

Seems like this is an IntPoint?  originInParent?  Or maybe we should compute
originInParent from offset?  In any case, "offset" needs a better name.  offset
to what?  offset in what?  what is "offset"?