[webkit-reviews] review granted: [Bug 60796] Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:] : [Attachment 93500] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 60796: Crash when code inside a ResourceLoadDelegate method calls [WebView
stopLoading:]
https://bugs.webkit.org/show_bug.cgi?id=60796

Attachment 93500: Patch v1
https://bugs.webkit.org/attachment.cgi?id=93500&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93500&action=review

> Source/WebCore/loader/ResourceLoader.cpp:359
> +    // off without re-running willCancel()

Missing period.

> Source/WebCore/loader/ResourceLoader.cpp:369
> +	   m_cancelled = true;

For callers of the cancelled() function, it might be better m_cancelled was set
to true even before calling willCancel. However, this is consistent with the
behavior we had before. I suggest we follow up by moving the m_cancelled
setting to before willCancel, which will require changing m_calledWillCancel
around a bit too. Lets do that in a followup, though.