[webkit-reviews] review granted: [Bug 60788] REGRESSION (r69790): WebKit2 doesn't prefer plugins in the additional plugins directory : [Attachment 93494] Load plugins in the order they're found

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 12:47:38 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 60788: REGRESSION (r69790): WebKit2 doesn't prefer plugins in the
additional plugins directory
https://bugs.webkit.org/show_bug.cgi?id=60788

Attachment 93494: Load plugins in the order they're found
https://bugs.webkit.org/attachment.cgi?id=93494&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93494&action=review

> Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:67
>  #if OS(WINDOWS)
> -typedef HashSet<String, CaseFoldingHash> PathHashSet;
> +typedef ListHashSet<String, 32, CaseFoldingHash> PathHashSet;
>  #else
> -typedef HashSet<String> PathHashSet;
> +typedef ListHashSet<String, 32> PathHashSet;
>  #endif

Please add a comment here explaining why wer're using a ListHashSet.


More information about the webkit-reviews mailing list