[webkit-reviews] review granted: [Bug 60711] Web Inspector: inspector console should be searchable : [Attachment 93309] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 60711: Web Inspector: inspector console should be searchable
https://bugs.webkit.org/show_bug.cgi?id=60711

Attachment 93309: Patch
https://bugs.webkit.org/attachment.cgi?id=93309&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93309&action=review

> Source/WebCore/inspector/front-end/ConsolePanel.js:114
> +    jumpToNextSearchResult: function()

This is a lot of boilerplate code. In this case (as well as in many other
cases), we have the whole list of search results synchronously. It would be
great if Panel could handle those by itself and was only telling its delegate
(ancestor) which result to highlight.