[webkit-reviews] review denied: [Bug 59655] GTK port of WebKit2 should switch to new DrawingAreaImpl model : [Attachment 93458] Patch without scrolling artifacts

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 59655: GTK port of WebKit2 should switch to new DrawingAreaImpl model
https://bugs.webkit.org/show_bug.cgi?id=59655

Attachment 93458: Patch without scrolling artifacts
https://bugs.webkit.org/attachment.cgi?id=93458&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93458&action=review

> Source/WebKit2/UIProcess/gtk/BackingStoreGtk.cpp:102
> +    GdkRectangle invalidatedRect = targetRect;
> +   
gdk_window_invalidate_rect(gtk_widget_get_window(m_webPageProxy->viewWidget()),

> +				  &invalidatedRect, FALSE);
> +}

This is not needed. Instead, you should implement PageClientImpl::scrollView
which will be called automatically after the backing store has been updated.