[webkit-reviews] review granted: [Bug 59157] ShadowContentElement should affect the order of renderer children : [Attachment 93410] Mark new tests missing expectations

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 59157: ShadowContentElement should affect the order of renderer children
https://bugs.webkit.org/show_bug.cgi?id=59157

Attachment 93410: Mark new tests missing expectations
https://bugs.webkit.org/attachment.cgi?id=93410&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93410&action=review

I am still not 100% happy with our TreeLocation/AttachPhase names. We need to
make them clearer -- consider reading this code through the eyes of someone who
doesn't understand shadow DOM or how it works. "Light", "Shadow", "Content" --
all these terms are only well-understood in the context of existing shadow DOM
knowledge. We should work to eliminate this knowledge requirement.

> Source/WebCore/dom/Node.cpp:1470
> +	   AttachStraight,

Straight seems awkward, but I can't think of a better name at the moment.

> Source/WebCore/dom/ShadowRoot.cpp:75
> +    // XXX: Make this lazy

Probably didn't mean to leave it this way?