[webkit-reviews] review granted: [Bug 60162] [NRWT] chromium-linux tests shouldn't run on other platforms : [Attachment 93449] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 13 07:43:48 PDT 2011
Csaba Osztrogonac <ossy at webkit.org> has granted Kristóf Kosztyó
<Kosztyo.Kristof at stud.u-szeged.hu>'s request for review:
Bug 60162: [NRWT] chromium-linux tests shouldn't run on other platforms
https://bugs.webkit.org/show_bug.cgi?id=60162
Attachment 93449: proposed fix
https://bugs.webkit.org/attachment.cgi?id=93449&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93449&action=review
LGTM, r=me with a little fix in changelog
> Tools/ChangeLog:9
> + Remove _tests_for_other_platforms defs because in the r82753
> + it is implemented properly in the baseclass in webkit.py
little nit: ... because r82753 implemented it properly ...
More information about the webkit-reviews
mailing list