[webkit-reviews] review requested: [Bug 60563] [Chromium]Click event is not fired for a menulist <select> : [Attachment 93407] EventHandler version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 23:48:15 PDT 2011


Naoki Takano <takano.naoki at gmail.com> has asked  for review:
Bug 60563: [Chromium]Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

Attachment 93407: EventHandler version
https://bugs.webkit.org/attachment.cgi?id=93407&action=review

------- Additional Comments from Naoki Takano <takano.naoki at gmail.com>
According to your suggestion, I changed to use EventHandler to forward the
event.

Actually, just forwarding doesn't work well because of coordinate issue.

As you know, user click the item in select option window, the mouse point is
out of bound from the actual select widget.
The event hander isn't fired correctly.

So, inspired by WebKit2 solution, I stored the mouse button down position
first, and use the location when the up.

I left dispatchMouseUpAndClick() in AutoFillPopupMenuClient.h, because I didn't
get your answer.

Please review again.

Thanks,


More information about the webkit-reviews mailing list