[webkit-reviews] review granted: [Bug 60685] Solar Walk For Mac: Info window is blank (HTML5 parser) : [Attachment 93384] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adele Peterson <adele at apple.com>'s
request for review:
Bug 60685: Solar Walk For Mac: Info window is blank (HTML5 parser)
https://bugs.webkit.org/show_bug.cgi?id=60685

Attachment 93384: patch
https://bugs.webkit.org/attachment.cgi?id=93384&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93384&action=review

> Source/WebKit/mac/WebView/WebView.mm:686
> +    NSLog(@"contents of user script: %@\n", solarWalkQuirksScriptContents);

Probably should take out this log before landing.

> Source/WebKit/mac/WebView/WebView.mm:688
> +    core(self)->group().addUserScriptToWorld(core([WebScriptWorld world]),
> +						solarWalkQuirksScriptContents,
KURL(), nullptr, nullptr, InjectAtDocumentEnd, InjectInAllFrames);

WebKit style says not to line subsequent lines up like this. (Too bad editors
all seem to want to do it.)