[webkit-reviews] review granted: [Bug 60735] Crash when a plug-in tries to load a resource from the application cache : [Attachment 93364] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 60735: Crash when a plug-in tries to load a resource from the application
cache
https://bugs.webkit.org/show_bug.cgi?id=60735

Attachment 93364: Patch
https://bugs.webkit.org/attachment.cgi?id=93364&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=93364&action=review

> Source/WebCore/ChangeLog:11
> +	   This lead to the plug-in stream loader canceling the load, something
which the application

typo: lead

> Source/WebCore/loader/DocumentLoader.cpp:601
> +
> +	       // Calling ResourceLoader::didReceiveResponse can end up
cancelling the load,
> +	       // so we need to check if the loader has reached its terminal
state.
> +	       if (loader->reachedTerminalState())
> +		   return;
> +
> +	       // Calling ResourceLoader::didReceiveData can end up cancelling
the load,
> +	       // so we need to check if the loader has reached its terminal
state.
>	       loader->didReceiveData(data->data(), data->size(), data->size(),
true);
> +	       if (loader->reachedTerminalState())

The inconsistent way you order the comments is weird and inconsistent.