[webkit-reviews] review denied: [Bug 60721] Marker test from ietestcenter fails : [Attachment 93344] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 60721: Marker test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=60721

Attachment 93344: Patch
https://bugs.webkit.org/attachment.cgi?id=93344&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93344&action=review

I'd like to see at least one more test, where you use inherit for display
<marker style="display:inherit" ...

r- because of the new test and the changelog.

> Source/WebCore/ChangeLog:9
> +
> +	   Allow <marker> to be referenced in case the display:none is set on
it
> +	   or any of the ancestors.

You're doing more now. Marker gets a Renderer, always. Also not sure what you
mean with referenced in the combination with display:none. Please add a more
detailed description what you changed, why you did it, Why it fixes the
problem. Add a link to the specification text.