[webkit-reviews] review granted: [Bug 60722] [Qt] fix http/tests/plugins/plugin-document-has-focus.html : [Attachment 93331] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 60722: [Qt] fix http/tests/plugins/plugin-document-has-focus.html
https://bugs.webkit.org/show_bug.cgi?id=60722

Attachment 93331: Patch
https://bugs.webkit.org/attachment.cgi?id=93331&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93331&action=review

I had a quick look, and this look sane ;)
Just a few comments.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:176
> +    if (!m_eventSender)
> +	   m_eventSender = new EventSender(this);

Can't this be initialized in the constructor of the page to simplify stuff a
bit?

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:787
> +    // Each page has its own event sender object, as it must install an
event filter in that page's view

I don't think you need a comment here.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:788
> +    if (frame->page())

Is this check really necessary? When is a frame be detached from the page?