[webkit-reviews] review denied: [Bug 30554] Web Inspector: Watched Expressions Buttons Do Not Match Inspector Styles : [Attachment 89766] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 13:12:16 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 30554: Web Inspector: Watched Expressions Buttons Do Not Match Inspector
Styles
https://bugs.webkit.org/show_bug.cgi?id=30554

Attachment 89766: Patch.
https://bugs.webkit.org/attachment.cgi?id=89766&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89766&action=review

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:204
> +	   this._lastMouseMoveEvent = e;

why storing events?

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:208
> +	   this._hoveredElement = this.propertiesElement.firstChild;

are you looking for event.target here?


More information about the webkit-reviews mailing list