[webkit-reviews] review canceled: [Bug 59596] Web Inspector: Move Resources Panel search to backend : [Attachment 91680] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 59596: Web Inspector: Move Resources Panel search to backend
https://bugs.webkit.org/show_bug.cgi?id=59596

Attachment 91680: Patch
https://bugs.webkit.org/attachment.cgi?id=91680&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91680&action=review

Couple of nits, otherwise looks good.

> Source/WebCore/inspector/Inspector.json:107
> +		       { "name": "matchesCount", "type": "number",
"description": "Number of matches in resource content." }

in _the_ resource content.

> Source/WebCore/inspector/InspectorPageAgent.cpp:531
> +void InspectorPageAgent::domContentEventFired()

I thought these were already a part of the file.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:706
> +		       var resource =
frameTreeElement.resourceByURL(searchResult.url);

You should check frame tree elements for null - they are very dynamic.