[webkit-reviews] review granted: [Bug 60585] Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize : [Attachment 93323] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 60585: Convert RenderBox::setLocation, setLogicalLocation and
setLogicalSize to IntPoint/IntSize
https://bugs.webkit.org/show_bug.cgi?id=60585

Attachment 93323: Patch
https://bugs.webkit.org/attachment.cgi?id=93323&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93323&action=review

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:329
> +	   IntPoint location(width() - borderRight() - paddingRight() -
spinBox->width(),
> +			     (diff / 2) + (diff % 2));

This indentation is not the WebKit coding style. I think you should just add
IntPoint around (x,y) instead of changing the code so much.