[webkit-reviews] review denied: [Bug 60440] [Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data : [Attachment 92980] patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 60440: [Qt] Redirection of HTTP POST (3xx) incorrectly includes original
POST data
https://bugs.webkit.org/show_bug.cgi?id=60440

Attachment 92980: patch
https://bugs.webkit.org/attachment.cgi?id=92980&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92980&action=review

> Source/WebCore/ChangeLog:9
> +	  Makes sure that the HTTP headers Content-type and Content-length are
not included in
> +	  the requests that do not have any content.

Indent issue?

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:618
> +    if (m_method != QNetworkAccessManager::PostOperation && m_method !=
QNetworkAccessManager::PutOperation) {

Looks like OPTION can also contain an entity-body:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.2

Would you mind checking OPTION?

Maybe the tests could loop over all the standards http method definitions?

This is a bit sidetrack from the original issue. If you prefer to do such
things in a separate bug report that is fine by me.