[webkit-reviews] review granted: [Bug 60274] [Windows WebKit2] Use cookies set in WebKit1 : [Attachment 93318] Patch with a better fix for the crash and with a fix for a loose end (Take 2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 11:54:42 PDT 2011


Darin Adler <darin at apple.com> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 60274: [Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Attachment 93318: Patch with a better fix for the crash and with a fix for a
loose end (Take 2)
https://bugs.webkit.org/attachment.cgi?id=93318&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93318&action=review

> Source/WebKit2/Shared/WebProcessCreationParameters.cpp:166
> -    if (parameters.serializedDefaultStorageSession &&
!CoreIPC::decode(decoder, parameters.serializedDefaultStorageSession))
> +    bool hasStorageSession = false;
> +    if (!decoder->decode(hasStorageSession))
> +	   return false;
> +    if (hasStorageSession && !CoreIPC::decode(decoder,
parameters.serializedDefaultStorageSession))
>	   return false;

What zeroes out parameters.serializedDefaultStorageSession?


More information about the webkit-reviews mailing list