[webkit-reviews] review granted: [Bug 60712] Regression caused by changeset 86281 : [Attachment 93316] Patch (v1)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jia Pu <jpu at apple.com>'s request for
review:
Bug 60712: Regression caused by changeset 86281
https://bugs.webkit.org/show_bug.cgi?id=60712

Attachment 93316: Patch (v1)
https://bugs.webkit.org/attachment.cgi?id=93316&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93316&action=review

I’m really worried about the thread-safety issues here.

> Source/WebKit/mac/ChangeLog:10
> +	   Need to clear m_view pointer in handleAcceptedReplacement(), since
this function can be invoked
> +	   by AppKit on different thread without going through
dismissInternal().

Does this code have enough locking for this to be called on a different
thread!?

> Source/WebKit2/ChangeLog:10
> +	   Need to clear m_view pointer in handleAcceptedReplacement(), since
this function can be invoked
> +	   by AppKit on different thread without going through
dismissInternal().

Does this code have enough locking for this to be called on a different
thread!?