[webkit-reviews] review granted: [Bug 60585] Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize : [Attachment 93313] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 12 11:27:28 PDT 2011
Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 60585: Convert RenderBox::setLocation, setLogicalLocation and
setLogicalSize to IntPoint/IntSize
https://bugs.webkit.org/show_bug.cgi?id=60585
Attachment 93313: Patch
https://bugs.webkit.org/attachment.cgi?id=93313&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93313&action=review
OK.
> Source/WebCore/rendering/RenderBox.h:83
> + setLocation(IntPoint(location.y(), location.x()));
Seems we want some sort of helper function to do this flip for us. Not
necessarily in this change, but eventually. :)
> Source/WebCore/rendering/RenderBox.h:104
> + setSize(IntSize(size.height(), size.width()));
Again here.
More information about the webkit-reviews
mailing list