[webkit-reviews] review requested: [Bug 60585] Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize : [Attachment 93313] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 11:23:12 PDT 2011


Emil A Eklund <eae at chromium.org> has asked  for review:
Bug 60585: Convert RenderBox::setLocation, setLogicalLocation and
setLogicalSize to IntPoint/IntSize
https://bugs.webkit.org/show_bug.cgi?id=60585

Attachment 93313: Patch
https://bugs.webkit.org/attachment.cgi?id=93313&action=review

------- Additional Comments from Emil A Eklund <eae at chromium.org>
> I don’t see why we can’t use roundedIntPoint here. Does it give the wrong
results for something?
No, it gives the same result for all cases I can come up with. 

Changed RenderBox::positionLineBox to use roundedIntPoint and removed new
rounding function.


More information about the webkit-reviews mailing list