[webkit-reviews] review requested: [Bug 60710] JavaScriptGlue should compile with -Wmissing-prototypes : [Attachment 93305] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 12 10:58:30 PDT 2011
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 60710: JavaScriptGlue should compile with -Wmissing-prototypes
https://bugs.webkit.org/show_bug.cgi?id=60710
Attachment 93305: Patch
https://bugs.webkit.org/attachment.cgi?id=93305&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
Enabling -Wmissing-prototypes fixes an Xcode 4 project warning.
This also fixes the following compiler warning:
JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function
'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3]
JSGlobalData* getThreadGlobalData()
^
* Configurations/Base.xcconfig: Set
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES.
* JSUtils.cpp:
(getThreadGlobalData): Made static.
---
3 files changed, 21 insertions(+), 2 deletions(-)
More information about the webkit-reviews
mailing list