[webkit-reviews] review canceled: [Bug 60681] Enable OwnPtr strict mode in PluginHalter : [Attachment 93286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 10:24:14 PDT 2011


Adam Barth <abarth at webkit.org> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 60681: Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681

Attachment 93286: Patch
https://bugs.webkit.org/attachment.cgi?id=93286&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Patrick, if you wouldn't mind re-doing this patch one more time, I think
keeping the current ownership model would be better than adding more "delete
this" calls.  Can we change the constructor to take a PassOwnPtr to document
that it is taking ownership of the client?


More information about the webkit-reviews mailing list