[webkit-reviews] review granted: [Bug 60247] Handle the touch icon in WebKit/Chromium : [Attachment 93193] Correct patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
michaelbai at chromium.org's request for review:
Bug 60247: Handle the touch icon in WebKit/Chromium
https://bugs.webkit.org/show_bug.cgi?id=60247

Attachment 93193: Correct patch
https://bugs.webkit.org/attachment.cgi?id=93193&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93193&action=review

> Source/WebKit/chromium/ChangeLog:9
> +	   Added a parameter to favIconURL() to specify the type of icon need
to

this is a bit stale.  it should also mention the method renaming.

> Source/WebKit/chromium/public/WebFrame.h:133
> +    // This method is deprecated and will be removed soon.

nit: we usually format comments like this for easy discovery later.

// DEPRECATED: Use iconIRLs instead.

> Source/WebKit/chromium/public/WebFrameClient.h:205
> +    // This method is deprecated and will be removed soon.

same nit...

// DEPRECATED: Implement didChangeIcon instead.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:764
> +	   // Keep the API work in the transient.

nit: this a good place to insert FIXME, again for easy discovery later.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:531
> +WebVector<WebIconURL> WebFrameImpl::iconURLs(int webIconTypes) const

nit: param should just be called iconTypes as it is declared in the header.