[webkit-reviews] review granted: [Bug 57843] Switch from Vector<UChar> to StringBuilder in dom/ : [Attachment 88225] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 57843: Switch from Vector<UChar> to StringBuilder in dom/
https://bugs.webkit.org/show_bug.cgi?id=57843

Attachment 88225: Patch
https://bugs.webkit.org/attachment.cgi?id=88225&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88225&action=review

>> Source/WebCore/dom/DatasetDOMStringMap.cpp:124
>> +		builder.append(toASCIILower(characters[i]));
> 
> Why characters[i] and not character? And why do you need the local
regardless?

I agree with both comments. There is little benefit to using the local, but if
we do use it we should use it in all three places.