[webkit-reviews] review granted: [Bug 60055] media/video-volume-slider.html causes GTK 64 bit debug bot to time out : [Attachment 93269] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 09:01:47 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 60055: media/video-volume-slider.html causes GTK 64 bit debug bot to time
out
https://bugs.webkit.org/show_bug.cgi?id=60055

Attachment 93269: updated patch
https://bugs.webkit.org/attachment.cgi?id=93269&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93269&action=review

> LayoutTests/media/video-volume-slider.html:30
> +		   x = muteCoords[0];
> +		   y = muteCoords[1];
>		   eventSender.mouseMoveTo(x, y);

You could just pass the coordinates directly here ala
eventSender.moveMouseTo(muteCoords[0], museCoords[1]); without much loss of
explication.


More information about the webkit-reviews mailing list