[webkit-reviews] review granted: [Bug 58863] [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing : [Attachment 93204] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 58863: [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html
failing
https://bugs.webkit.org/show_bug.cgi?id=58863

Attachment 93204: Patch
https://bugs.webkit.org/attachment.cgi?id=93204&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93204&action=review

Pretty nice!

> Source/WebCore/platform/qt/PlatformMouseEventQt.cpp:114
> +    // FIXME: Why don't we handle a context menu event here as we do in
PlatformMouseEvent(QInputEvent*, int)?

Maybe Benjamin would know... he dealt a bit with that for webkit2