[webkit-reviews] review denied: [Bug 60412] Page::goToItem doesn't work while loading is deferred : [Attachment 92862] perhaps this will appease the bots?

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ian Henderson <ianh at apple.com>'s
request for review:
Bug 60412: Page::goToItem doesn't work while loading is deferred
https://bugs.webkit.org/show_bug.cgi?id=60412

Attachment 92862: perhaps this will appease the bots?
https://bugs.webkit.org/attachment.cgi?id=92862&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92862&action=review

> Source/WebCore/page/Page.h:407
> +	   RefPtr<HistoryItem> m_deferredItem;
> +	   FrameLoadType m_deferredFrameLoadType;

I suspect that this isn't the best place for this data.  Generally, the large
"hub" objects like Frame and Page shouldn't hold much data themselves because
they become "dumping grounds" for lots of unrelated stuff.  I haven't fully
understood what your patch does, but these seem related to history, so perhaps
the HistoryController is a more appropriate place?