[webkit-reviews] review granted: [Bug 60407] IndexedDB: add detail to an ASSERT error message : [Attachment 92646] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 19:39:26 PDT 2011


Eric Seidel <eric at webkit.org> has granted David Grogan <dgrogan at chromium.org>'s
request for review:
Bug 60407: IndexedDB: add detail to an ASSERT error message
https://bugs.webkit.org/show_bug.cgi?id=60407

Attachment 92646: Patch
https://bugs.webkit.org/attachment.cgi?id=92646&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92646&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This will cause the cq to fail.  You should just explain why testing isn't
needed or possible.  In this case, because this is just a debug ASSERT. :)


More information about the webkit-reviews mailing list