[webkit-reviews] review granted: [Bug 35573] WebSocket add new event: CloseEvent : [Attachment 93107] Update Chromium test results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 18:33:42 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 35573: WebSocket add new event: CloseEvent
https://bugs.webkit.org/show_bug.cgi?id=35573

Attachment 93107: Update Chromium test results
https://bugs.webkit.org/attachment.cgi?id=93107&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93107&action=review

> LayoutTests/http/tests/websocket/tests/close-event.html:22
> +if (window.layoutTestController)
> +    layoutTestController.waitUntilDone();
> +
> +function endTest()
> +{
> +    isSuccessfullyParsed();
> +    if (window.layoutTestController)
> +	   layoutTestController.notifyDone();
> +}

We can simplify this by
window.jsTestIsAsync = true;
 and
replacing endTest() with finishJSTest().


More information about the webkit-reviews mailing list