[webkit-reviews] review denied: [Bug 60681] Enable OwnPtr strict mode in PluginHalter : [Attachment 93229] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 11 18:17:50 PDT 2011
Adam Barth <abarth at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 60681: Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681
Attachment 93229: Patch
https://bugs.webkit.org/attachment.cgi?id=93229&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93229&action=review
I'm worried that this is going to create leaks. I don't think we fully
understand how memory is managed for the other clients and whether this client
is different for a reason.
> Source/WebCore/ChangeLog:9
> + PluginHalterClien gets allocated in WebKit code, so deleting it in
WebCore is wrong.
PluginHalterClien => PluginHalterClient
More information about the webkit-reviews
mailing list