[webkit-reviews] review denied: [Bug 60676] Enable OwnPtr strict mode in libxml2 XMLDocumentParser : [Attachment 93222] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 60676: Enable OwnPtr strict mode in libxml2 XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=60676

Attachment 93222: Patch
https://bugs.webkit.org/attachment.cgi?id=93222&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93222&action=review

> Source/WebCore/dom/XMLDocumentParserLibxml2.cpp:191
> -	   OwnPtr<PendingCallback> callback(m_callbacks.takeFirst());
> +	   OwnPtr<PendingCallback> callback =
adoptPtr(m_callbacks.takeFirst());

This change is not correct.  m_callbacks should old OwnPtrs and takeFirst
should return a PassOwnPtr.  I thought Maceij wrote a patch that did that? 
Maybe he added the ability to Deque but didn't change the type in this file?