[webkit-reviews] review granted: [Bug 60008] [chromium] Use mapTexSubImage2D for tile uploads if available : [Attachment 93205] Check for mapsub once.

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 60008: [chromium] Use mapTexSubImage2D for tile uploads if available
https://bugs.webkit.org/show_bug.cgi?id=60008

Attachment 93205: Check for mapsub once.
https://bugs.webkit.org/attachment.cgi?id=93205&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93205&action=review

R=me

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:125
>      m_contextSupportsLatch =
m_context->getExtensions()->supports("GL_CHROMIUM_latch");
> +    m_contextSupportsMapSub =
m_context->getExtensions()->supports("GL_CHROMIUM_map_sub");
> +    if (m_contextSupportsMapSub)
> +	   m_context->getExtensions()->ensureEnabled("GL_CHROMIUM_map_sub");

hmm, looks like I should go ask John Bates about why we aren't calling
ensureEnabled("GL_CHROMIUM_latch").