[webkit-reviews] review granted: [Bug 60596] Switch paintFillLayer and its progeny to use IntRect instead of four ints : [Attachment 93200] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 60596: Switch paintFillLayer and its progeny to use IntRect instead of four
ints
https://bugs.webkit.org/show_bug.cgi?id=60596

Attachment 93200: Patch
https://bugs.webkit.org/attachment.cgi?id=93200&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93200&action=review

OK.

> Source/WebCore/rendering/InlineFlowBox.cpp:1061
> +	   paintInfo.context->clip(IntRect(rect.x(), rect.y(), width(),
height()));

rect.location(), size()?

> Source/WebCore/rendering/InlineFlowBox.cpp:1062
> +	   boxModelObject()->paintFillLayerExtended(paintInfo, c, fillLayer,
IntRect(stripX, stripY, stripWidth, stripHeight), BackgroundBleedNone, this,
rect.size(), op);

looks like stripRect is gonna be next. :)