[webkit-reviews] review granted: [Bug 60561] [Qt] Implements a disable appearance for Media Elements of Qt port. : [Attachment 93166] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 60561: [Qt] Implements a disable appearance for Media Elements of Qt port.
https://bugs.webkit.org/show_bug.cgi?id=60561

Attachment 93166: Patch
https://bugs.webkit.org/attachment.cgi?id=93166&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93166&action=review

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1232
> +    if (!mediaElementCanPlay(o))
> +	   fgColor = Qt::gray;

Is disabled always grey with all themes?

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1455
> +    p.painter->setBrush(getMediaControlForegroundColor(o->parent()));

Maybe make it more clear who is the parent here