[webkit-reviews] review denied: [Bug 60625] Cleanup RenderSVGPath to offer a non-marker variant : [Attachment 93173] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 60625: Cleanup RenderSVGPath to offer a non-marker variant
https://bugs.webkit.org/show_bug.cgi?id=60625

Attachment 93173: Patch
https://bugs.webkit.org/attachment.cgi?id=93173&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93173&action=review

I'm not happy about the virtual functions. They are unnecessary for rect,
circle and co. Rob will test if transforming SVGMarkerLayoutInfo
m_markerLayoutInfo to an OwnPtr could be an compromise. r- for the meantime.

> Source/WebCore/rendering/svg/RenderSVGPath.h:69
> +    virtual FloatRect calculateMarkerBoundsIfNeeded() { return FloatRect();
}

the '&'  is on the wrong place. Doesn't match webkit style.

> Source/WebCore/rendering/svg/RenderSVGPath.h:109
> +    OwnPtr<SVGMarkerLayoutInfo> &markerLayoutInfo()

Ditto.