[webkit-reviews] review denied: [Bug 60630] Web Inspector: hovering over linkified nodes in the UI does not highlight elements on the page. : [Attachment 93125] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 60630: Web Inspector: hovering over linkified nodes in the UI does not
highlight elements on the page.
https://bugs.webkit.org/show_bug.cgi?id=60630

Attachment 93125: Patch
https://bugs.webkit.org/attachment.cgi?id=93125&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93125&action=review

> Source/WebCore/inspector/front-end/inspector.js:322
> +	   element.addEventListener("mouseover",
this.highlightDOMNode.bind(this, nodeId, "all"), false);

How does it differ from the current behavior? Looking at inspector.js:308 I see
this:
DOMAgent.highlightNode(nodeId, mode || "all"); which is equivalent to passing
"all" explicitely. Should we require mode parameter?