[webkit-reviews] review requested: [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces : [Attachment 93152] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 11:36:56 PDT 2011


Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 57543: -webkit-visual-word does not work on words separated by multiple
spaces
https://bugs.webkit.org/show_bug.cgi?id=57543

Attachment 93152: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=93152&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
updated per comment #18.

>> Source/WebCore/editing/visible_units.cpp:1297
>> +	const InlineBox* box, const VisiblePosition& previousWordBreak, int&
offsetOfWordBreak, bool& isLastWordBreakInBox, bool&
previousWordBreakIsInBoundary)

>Nit: s/previousWordBreakIsInBoundary/previousWordBreakWasAtBoundary/

>In addition, it'll be nice to say whether it's at start (left for LTR/right
for RTL) or end (right for LTR/left for RTL).

changed it to previousWordBreakWasAtBoxStart.


More information about the webkit-reviews mailing list