[webkit-reviews] review granted: [Bug 60521] Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON. : [Attachment 93142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 10:26:34 PDT 2011


Ojan Vafai <ojan at chromium.org> has granted Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 60521: Modify jsonresults_unittest.py to use a dict format for its test
data, and modify jsonresults.py to flatten hierarchical directory structures in
input JSON.
https://bugs.webkit.org/show_bug.cgi?id=60521

Attachment 93142: Patch
https://bugs.webkit.org/attachment.cgi?id=93142&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93142&action=review

> Tools/TestResultServer/model/jsonresults.py:48
> +JSON_RESULTS_PARTIALLY_SUPPORTED_VERSION = 4

Don't love this name. How about JSON_RESULTS_HIERARCHICAL_VERSION?


More information about the webkit-reviews mailing list