[webkit-reviews] review denied: [Bug 58435] [Qt] Upstream Symbian platform plugin. : [Attachment 93124] platformpluginV22

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has denied yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 58435: [Qt] Upstream Symbian platform plugin.
https://bugs.webkit.org/show_bug.cgi?id=58435

Attachment 93124: platformpluginV22
https://bugs.webkit.org/attachment.cgi?id=93124&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93124&action=review

Almost there :D, just very unhappy with the QToolButton.

> Source/WebKit/qt/symbian/platformplugin/HTML5VideoPlugin.cpp:38
> +    m_videoWidget = new HTML5VideoWidget(player->duration() / 1000);

Please call setDuration and remove it from the constructor.

> Source/WebKit/qt/symbian/platformplugin/HTML5VideoWidget.cpp:23
> +HTML5VideoWidget::HTML5VideoWidget(int duration, QWidget *parent)

why the duration as parameter? You can call setDuration afterwards.