[webkit-reviews] review denied: [Bug 60624] Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation : [Attachment 93115] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 60624: Web Inspector: use InstrumentingAgents to access agents from
InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=60624

Attachment 93115: Patch
https://bugs.webkit.org/attachment.cgi?id=93115&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93115&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:457
> +    if (!instrumentingAgents)

Can this be 0?

> Source/WebCore/inspector/InspectorInstrumentation.h:908
> +    if (InstrumentingAgents* instrumentingAgents =
instrumentingAgentsWithFrontendForPage(page))

This does not make sense - instrumentingAgentsWithFrontend && hasFrontend?

> Source/WebCore/inspector/InspectorInstrumentation.h:938
> +    return instrumentingAgentsForFrame(frame);

Now you need to test whether there is a front-end for the page.

> Source/WebCore/inspector/InspectorInstrumentation.h:952
> +    return instrumentingAgentsForContext(context);

ditto

> Source/WebCore/inspector/InspectorInstrumentation.h:958
> +	   return instrumentingAgentsForPage(document->page());

ditto