[webkit-reviews] review canceled: [Bug 60174] Fix getUserMedia callback bindings for JSC : [Attachment 92619] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 05:51:33 PDT 2011


Adam Bergkvist <adam.bergkvist at ericsson.com> has canceled Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 60174: Fix getUserMedia callback bindings for JSC
https://bugs.webkit.org/show_bug.cgi?id=60174

Attachment 92619: Updated patch
https://bugs.webkit.org/attachment.cgi?id=92619&action=review

------- Additional Comments from Adam Bergkvist <adam.bergkvist at ericsson.com>
I agree. I made the mistake of trying to get an existing test to pass instead
of checking the specification for the correct behavior. According to the
specification there should never be any type mismatch errors and getUserMedia
should fail silently if successCallback is null. If options end up being
"undefined" a NOT_SUPPORTED_ERR exception will be thrown at a later stage. I
have created a separate bug to fix this (see http://webkit.org/b/60622).


More information about the webkit-reviews mailing list