[webkit-reviews] review granted: [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch : [Attachment 93021] Patch 9: TextureMapperNode refactoring

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 60439: [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2
branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Attachment 93021: Patch 9: TextureMapperNode refactoring
https://bugs.webkit.org/attachment.cgi?id=93021&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93021&action=review

Great stuff, nice to finally get our delta upstreamed

> Source/WebCore/ChangeLog:14
> +	   1. Support the new TextureMapperPlatformLayer for media & WebGL.
> +	   2. Use a pool for intermediate surfaces, to avoid constant
allocating/freeing of textures.
> +	   3. Divide computation operations to different smaller functions.
> +	   4. Get rid of scissor/clip layers, use transformed clip instead.
> +	   5. Allow tiling for big layers.

In the future it would be nice with these as separate patches, but as we have
gone thru these patches together in real life, I accept it this time :-)

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:395
> +	   if (m_state.replicaLayer && !options.isSurface)
> +	      
m_currentContent.media->paintToTextureMapper(options.textureMapper, targetRect,

> +							   
TransformationMatrix(m_transforms.target).multiply(m_state.replicaLayer->m_tran
sforms.local),
> +							    opacity *
m_state.replicaLayer->m_opacity,
> +							    replicaMaskTexture
? replicaMaskTexture.get() : maskTexture.get());

That if needs braces