[webkit-reviews] review denied: [Bug 60583] DOMFileSystemBase should not impose file naming restrictions on 'external' filesystems : [Attachment 93012] Prevented DOMFileSystemBase from imposing file naming restrictions on external file systems

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 22:24:45 PDT 2011


Eric Seidel <eric at webkit.org> has denied Zelidrag Hornung
<zelidrag at chromium.org>'s request for review:
Bug 60583: DOMFileSystemBase should not impose file naming restrictions on
'external' filesystems
https://bugs.webkit.org/show_bug.cgi?id=60583

Attachment 93012: Prevented DOMFileSystemBase from imposing file naming
restrictions on external file systems
https://bugs.webkit.org/attachment.cgi?id=93012&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93012&action=review

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

This will make the commit-queue fail. You should explain why there are no new
tests (is testing impossible here?)  or you should add tests.

Also, the FileSystem feature should be announced on webkit-dev per the new
feature guidelines:
http://www.webkit.org/coding/adding-features.html


More information about the webkit-reviews mailing list