[webkit-reviews] review denied: [Bug 60518] Expose willStartLiveResize and willEndLiveResize in WebView : [Attachment 92963] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 22:03:51 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 60518: Expose willStartLiveResize and willEndLiveResize in WebView
https://bugs.webkit.org/show_bug.cgi?id=60518

Attachment 92963: Patch
https://bugs.webkit.org/attachment.cgi?id=92963&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92963&action=review

> Source/WebKit/chromium/public/WebView.h:139
> +    virtual void willStartLiveResize() = 0;

please move to WebWidget.  i think you can try to define these better instead
of referring to some OSX behavior.  this API should be well defined so other
ports can understand how to use it.  see my previous note.  i think this is
intended to bound a sequence of resize commands so the implementation can show
UI related to such an interaction.


More information about the webkit-reviews mailing list