[webkit-reviews] review denied: [Bug 58847] REGRESSION(r84099): It made two Qt API tests fail : [Attachment 93026] Changed baseURL to allow them to create a local storage when needed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 16:07:27 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 58847: REGRESSION(r84099): It made two Qt API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58847

Attachment 93026: Changed baseURL to allow them to create a local storage when
needed.
https://bugs.webkit.org/attachment.cgi?id=93026&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
I think having a valid security origin in order to get local storage is
reasonable.

But, I r- because I think you should have test for both behavior. Testing that
"no security origin"->"local storage disabled" would be good to avoid future
regressions.


More information about the webkit-reviews mailing list