[webkit-reviews] review granted: [Bug 58863] [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing : [Attachment 92589] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 58863: [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html
failing
https://bugs.webkit.org/show_bug.cgi?id=58863

Attachment 92589: Patch
https://bugs.webkit.org/attachment.cgi?id=92589&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92589&action=review

Make sense, just check this:

> Source/WebCore/platform/qt/PlatformMouseEventQt.cpp:38
> +static MouseButton mouseButtonForQtMouseButtons(Qt::MouseButtons
mouseButtons)
> +{

I would prefer this to take the event as the parameter.
This way, the test "m_eventType == MouseEventMoved ? event->buttons() :
event->button()" can be done in this function instead of being repeated by the
callers.