[webkit-reviews] review denied: [Bug 60359] Web Inspector: move agents from InspectorAgent to InspectorController : [Attachment 92931] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 60359: Web Inspector: move agents from InspectorAgent to
InspectorController
https://bugs.webkit.org/show_bug.cgi?id=60359

Attachment 92931: Patch
https://bugs.webkit.org/attachment.cgi?id=92931&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92931&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:796
> +    if (InspectorDebuggerAgent* debuggerAgent =
inspectorAgent->instrumentingAgents()->inspectorDebuggerAgent())

I think it is time to store instrumenting agents pointer in a map within
InspectorInstrumentation. It does not make sense to access it via
inspectorAgent.