[webkit-reviews] review denied: [Bug 60548] [Chromium] Add rebaselines for video-layer-crash. : [Attachment 92948] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 09:51:49 PDT 2011


David Levin <levin at chromium.org> has denied imasaki at chromium.org's request for
review:
Bug 60548: [Chromium] Add rebaselines for video-layer-crash.
https://bugs.webkit.org/show_bug.cgi?id=60548

Attachment 92948: Patch
https://bugs.webkit.org/attachment.cgi?id=92948&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92948&action=review

> LayoutTests/ChangeLog:9
> +	   failing for a long time so rebaselines are necessary. We

Sorry, this explanation doesn't make sense to me. There are a lot of tests that
have been failing for a long time but we shouldn't just rebaseline them.
Perhaps, you just meant to say that the image needs to be updated because it is
incorrect (but the reason why this change happened isn't easily determined at
present because the test has been broken for so long).

Is the new baseline correct? (It looks like there isn't much difference from
the old image so it probably is.)


More information about the webkit-reviews mailing list