[webkit-reviews] review granted: [Bug 60532] Fixed up some #include dependencies so the WriteBarrier class can actually call Heap::writeBarrier : [Attachment 92922] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 60532: Fixed up some #include dependencies so the WriteBarrier class can
actually call Heap::writeBarrier
https://bugs.webkit.org/show_bug.cgi?id=60532

Attachment 92922: Patch
https://bugs.webkit.org/attachment.cgi?id=92922&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92922&action=review

r=me, but I think you need to find out why this failed on the Mac EWS

> Source/JavaScriptCore/heap/MarkStack.h:42
> +    template <typename T> class WriteBarrierBase;

I think we should consider a style guideline of omitting the space between the
word template and the <> arguments, by analogy with how there is no space after
a function name before its () arguments.

> Source/JavaScriptCore/heap/MarkStack.h:65
> +	   inline void appendValues(WriteBarrierBase<Unknown>*, size_t count,
MarkSetProperties = NoNullValues);

I believe the inline keyword here has no effect and so should be omitted.