[webkit-reviews] review denied: [Bug 60536] [GTK] Remove some unneeded header includes : [Attachment 92926] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 60536: [GTK] Remove some unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=60536

Attachment 92926: Patch
https://bugs.webkit.org/attachment.cgi?id=92926&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92926&action=review

Typically

> Source/WebCore/bindings/js/ScriptControllerGtk.cpp:37
> -#include "PluginView.h"
>  #include "runtime_root.h"
> +#include <WebCore/plugins/PluginView.h>
>  

Since this includes a header inside WebCore it doesn't seem right to use a
system include here. Is this change necessary?

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:30
>  #include "config.h"
> -#include "PluginView.h"
> +#include <WebCore/plugins/PluginView.h>

It's definitely not usual to do that here.